[codex] fix(vscode): force-kill unresponsive reviews#489
Draft
cosin2077 wants to merge 1 commit into
Draft
Conversation
|
|
Contributor
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The VS Code extension sends
SIGTERMwhen a user cancels an active review and is intended to escalate toSIGKILLafter three seconds if the CLI process does not exit.Root cause
ChildProcess.killedonly indicates that a signal was successfully sent. It does not indicate that the child process has exited. A process that ignoresSIGTERMtherefore haskilled === truewhileexitCodeandsignalCoderemainnull, preventing the existing timeout from ever sendingSIGKILL.Fix
exitCodeandsignalCodeto determine whether the child is still running before escalating toSIGKILL.closeto avoid signaling a process that already exited.SIGTERM.Verification
yarn install --frozen-lockfile(Node.js 24.18.0)yarn lint- 0 errors (1 pre-existing warning inIdleView.tsx)yarn test --runInBand- 11 suites, 94/94 tests passedyarn build- production webpack build passedRelated